-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Visual Builder to TSVB #39125
Conversation
Pinging @elastic/kibana-app |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Change the sorting of the tested chart type and we are ok to merge
@@ -46,7 +46,7 @@ export default function ({ getService, getPageObjects }) { | |||
'Region Map', | |||
'Tag Cloud', | |||
'Timelion', | |||
'Timeseries', | |||
'TSVB', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorting, Tim, sorting..... I told you 100 times 🤣 TSVB
before Tag Cloud
.
❤️ A, B, C, AA, AB, AC, Aa, Ab, Ac, a, b, c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still learning the alphabet sorry :-( Do you have any good learning resources on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
💚 Build Succeeded |
* Rename Visual Builder to TSVB * A, B, C, D, E, F, G ...
* Rename Visual Builder to TSVB * A, B, C, D, E, F, G ...
Summary
Renames Visual Builder to TSVB which it was already known as and referenced as for a long time.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately