Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Assistant] V2 Knowledge Base Settings feedback and fixes #194354

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spong
Copy link
Member

@spong spong commented Sep 27, 2024

Summary

This PR is a follow up to #192665 and addresses a bunch of feedback and fixes including:

  • Adds support for updating/editing entries
  • Fixes initial loading experience of the KB Settings Setup/Table
  • Fixes two bugs where semantic_text and text must be declared for IndexEntries to work

TODO:

  • Add support for required entries in initial prompt
  • Add suggestions to index and fields inputs
  • Add new Settings Context Menu items for KB and Alerts
  • Adds URL deeplinking to securityAssistantManagement
  • Fix bug where updating entry does not re-create embeddings
  • Fix loading indicators when adding/editing entries
  • API integration tests for update API

Checklist

Delete any items that are not applicable to this PR.

…elds for indexEntries, and plumbs dataViews for autocomplete
@spong spong added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Feature:Security Assistant Security Assistant Team:Security Generative AI Security Generative AI v8.16.0 backport:version Backport to applied version labels labels Sep 27, 2024
@spong spong self-assigned this Sep 27, 2024
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Security Assistant Security Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants