[Spaces Management] Fix issue with enabled features selection when space solution is unselected #194352
Conversation
tsullivan
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
|
Flaky test runner results https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7029 |
| return ( | ||
| <> | ||
| {doShowAlteringActiveSpaceDialog()} | ||
| {doShowConfirmDeleteSpaceDialog()} | ||
|
|
||
| <CustomizeSpace | ||
| space={formValues} | ||
| space={getSpaceFromFormValues(formValues)} |
There was a problem hiding this comment.
This ensures that default initials are used, if the space attributes doesn't have that field.
| @@ -137,7 +143,7 @@ export const EditSpaceSettingsTab: React.FC<Props> = ({ space, features, history | |||
| setIsLoading(true); | |||
|
|
|||
| let disabledFeatures: string[] | undefined; | |||
| if (spaceClone.solution === SOLUTION_VIEW_CLASSIC) { | |||
| if (spaceClone.solution == null || spaceClone.solution === SOLUTION_VIEW_CLASSIC) { | |||
There was a problem hiding this comment.
If the space was created via an API, then the solution field could be blank. The SpaceValidator treats that as a non-issue, and this code change follows that standard.
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7029[✅] x-pack/test/functional/apps/spaces/solution_view_flag_enabled/config.ts: 42/42 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Summary
The feature PR for the new UX in Spaces Management introduced a new editing screen for Spaces. Inadvertently, it introduced a bug where the user's selection of visible features is ignored unless the user has explicitly selected a solution view. This PR fixes that issue as well as adds tests to prevent any future regressions.
Also, this PR fixes an issue where the space initials could be left blank, which was another regression.
Checklist
Delete any items that are not applicable to this PR.