Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search session filter functional test #193812

Merged

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Sep 24, 2024

Summary

Fixes #192510.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lukasolson lukasolson added failed-test A test failure on a tracked branch, potentially flaky-test skipped-test v9.0.0 Feature:Search Sessions v8.16.0 labels Sep 24, 2024
@lukasolson lukasolson self-assigned this Sep 24, 2024
@lukasolson lukasolson requested a review from a team as a code owner September 24, 2024 02:48
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7000

[❌] test/plugin_functional/config.ts: 0/25 tests passed.

see run history

@lukasolson lukasolson added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.15) the previous major branch and all later branches still in development labels Sep 24, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7009

[✅] test/plugin_functional/config.ts: 25/25 tests passed.

see run history

@lukasolson lukasolson added the release_note:skip Skip the PR/issue when compiling release notes label Sep 24, 2024
Comment on lines +122 to +123
// For some reason, when loading the dashboard, sometimes the filter doesn't show up, so we
// refresh until it shows up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it sounds like this may be catching an actual issue in Dashboard. I wonder if anyone from @elastic/kibana-presentation has an idea of why this started failing a couple of weeks ago?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #194307 to track

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Created a followup issue on our end to revert this change once the Dashboard issue is resolved: #194331.

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines +122 to +123
// For some reason, when loading the dashboard, sometimes the filter doesn't show up, so we
// refresh until it shows up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Created a followup issue on our end to revert this change once the Dashboard issue is resolved: #194331.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson added backport:version Backport to applied version labels and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.15) the previous major branch and all later branches still in development labels Sep 27, 2024
@lukasolson lukasolson merged commit a9fa11e into elastic:main Sep 27, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11077292852

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 193812

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels failed-test A test failure on a tracked branch, potentially flaky-test Feature:Search Sessions release_note:skip Skip the PR/issue when compiling release notes skipped-test v8.16.0 v9.0.0
Projects
None yet
5 participants