Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Infra] Fix react query closing x in a non development env (#191276) #191281

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…91276)

Closes [elastic#190220](elastic#190220)

## Summary

This PR removes the `x` icon used to close the react query dev tools
which appeared in a non-development environment by restricting it to
appear only in development mode.

| before | after |
|-------|-------|
| <img width="1907" alt="image"
src="https://github.com/user-attachments/assets/28e68139-8f8b-4f13-aea3-76f9971b1ac0">
| <img width="1902" alt="image"
src="https://github.com/user-attachments/assets/7649f310-c531-4a01-aae4-c423c811cc48">
|

In a development environment, the icon stays and works as before:

<img width="1890" alt="image"
src="https://github.com/user-attachments/assets/a7cd7479-f1cd-4504-812d-b3ade903dfb7">

(cherry picked from commit 746662e)
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 26, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: ef27b1c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-191281-ef27b1c1f517

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB -349.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

@kibanamachine kibanamachine merged commit 392ed7f into elastic:8.15 Aug 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants