[EDR Workflows] Fix breakpoints on protections settings cards in Fleet #191262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
Team:Defend Workflows
szwarckonrad
changed the title
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
ashokaditya
approved these changes
Aug 26, 2024
ashokaditya
reviewed
Aug 26, 2024
| @@ -127,7 +127,7 @@ export const SettingCard: FC<SettingCardProps> = memo( | |||
| )} | |||
| </EuiFlexGroup> | |||
| </EuiFlexItem> | |||
| <EuiShowFor sizes={['m', 'l', 'xl']}> | |||
| <EuiShowFor sizes={['m', 'l', 'xl', 'xxl']}> | |||
There was a problem hiding this comment.
If there's no test for this toggle being visible on the card then we should add that test.
…szwarckonrad/kibana into fix-protection-card-breakpoints
ashokaditya
reviewed
Aug 26, 2024
| @@ -61,4 +61,16 @@ describe('Policy form SettingCard component', () => { | |||
| expect(renderResult.getByTestId('test-rightCornerContainer')).not.toBeEmptyDOMElement(); | |||
| expect(renderResult.getByTestId('test-rightContent')); | |||
| }); | |||
|
|
|||
| it('should show right corner content in viewport width greater than 1600px', () => { | |||
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 26, 2024
elastic#191262) Due to the lack of a defined xxl breakpoint, the protection card's toggle is not displayed on the Fleet integration page. https://github.com/user-attachments/assets/59b19051-997d-4fba-84e9-56dca45cf91e With addition of `xxl` breakpoint condition for `EuiShowFor` component the view is being rendered as expected https://github.com/user-attachments/assets/6933269d-f266-4096-8bf1-4234cd7b2302 No regression was observed on the Security Management pages. https://github.com/user-attachments/assets/a0f412a6-daa9-4595-8293-2d44aae3078a Works as expected on `8.15` branch. (cherry picked from commit 64b79d7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 26, 2024
…in Fleet (#191262) (#191298) # Backport This will backport the following commits from `main` to `8.15`: - [[EDR Workflows] Fix breakpoints on protections settings cards in Fleet (#191262)](#191262) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2024-08-26T16:42:17Z","message":"[EDR Workflows] Fix breakpoints on protections settings cards in Fleet (#191262)\n\nDue to the lack of a defined xxl breakpoint, the protection card's\r\ntoggle is not displayed on the Fleet integration page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59b19051-997d-4fba-84e9-56dca45cf91e\r\n\r\nWith addition of `xxl` breakpoint condition for `EuiShowFor` component\r\nthe view is being rendered as expected\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6933269d-f266-4096-8bf1-4234cd7b2302\r\n\r\nNo regression was observed on the Security Management pages.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a0f412a6-daa9-4595-8293-2d44aae3078a\r\n\r\nWorks as expected on `8.15` branch.","sha":"64b79d725dae3a3aff4246d3315e36f6837cc9b6","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","8.15 candidate","v8.16.0","v8.15.1"],"title":"[EDR Workflows] Fix breakpoints on protections settings cards in Fleet","number":191262,"url":"https://github.com/elastic/kibana/pull/191262","mergeCommit":{"message":"[EDR Workflows] Fix breakpoints on protections settings cards in Fleet (#191262)\n\nDue to the lack of a defined xxl breakpoint, the protection card's\r\ntoggle is not displayed on the Fleet integration page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59b19051-997d-4fba-84e9-56dca45cf91e\r\n\r\nWith addition of `xxl` breakpoint condition for `EuiShowFor` component\r\nthe view is being rendered as expected\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6933269d-f266-4096-8bf1-4234cd7b2302\r\n\r\nNo regression was observed on the Security Management pages.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a0f412a6-daa9-4595-8293-2d44aae3078a\r\n\r\nWorks as expected on `8.15` branch.","sha":"64b79d725dae3a3aff4246d3315e36f6837cc9b6"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191262","number":191262,"mergeCommit":{"message":"[EDR Workflows] Fix breakpoints on protections settings cards in Fleet (#191262)\n\nDue to the lack of a defined xxl breakpoint, the protection card's\r\ntoggle is not displayed on the Fleet integration page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/59b19051-997d-4fba-84e9-56dca45cf91e\r\n\r\nWith addition of `xxl` breakpoint condition for `EuiShowFor` component\r\nthe view is being rendered as expected\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6933269d-f266-4096-8bf1-4234cd7b2302\r\n\r\nNo regression was observed on the Security Management pages.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a0f412a6-daa9-4595-8293-2d44aae3078a\r\n\r\nWorks as expected on `8.15` branch.","sha":"64b79d725dae3a3aff4246d3315e36f6837cc9b6"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the lack of a defined xxl breakpoint, the protection card's toggle is not displayed on the Fleet integration page.
Screen.Recording.2024-08-26.at.10.37.36.mov
With addition of
xxlbreakpoint condition forEuiShowForcomponent the view is being rendered as expectedScreen.Recording.2024-08-26.at.11.36.27.mov
No regression was observed on the Security Management pages.
Screen.Recording.2024-08-26.at.11.37.16.mov
Works as expected on
8.15branch.