[Synthtrace] Support Non-ECS Logs #191086
Merged
+225
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedhamed-ahmed
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
cauemarcondes
approved these changes
Sep 3, 2024
| @@ -53,6 +53,17 @@ export class SynthtraceEsClient<TFields extends Fields> { | |||
| )}"` | |||
| ); | |||
|
|
|||
| const resolvedIndices = this.indices.length | |||
| ? ( | |||
| await this.client.indices.resolveIndex({ | |||
There was a problem hiding this comment.
Thanks for that, I was doing the same thing on another PR that hasn't been merged yet 😆
| await this.client.indices.resolveIndex({ | ||
| name: this.indices.join(','), | ||
| expand_wildcards: ['open', 'hidden'], | ||
| // @ts-expect-error ignore_unavailable is not in the type definition, but it is accepted by es |
There was a problem hiding this comment.
nit: If you want you can create a PR to fix this type issue like i did once upon a time - elastic/elasticsearch-specification#2653
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 3759
📝 Summary
This PR creates a new scenario with different non ECS fields as below :
The above fields are applied with different variances as below :
🎥 Demo
node scripts/synthtrace simple_non_ecs_logs.tsnonEcs.mov