Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine] Update toast message for adding exception #191032

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Aug 21, 2024

Summary

Addresses #156246

Updates exception toast message to accurately reflect when it's an endpoint exception.

Screenshot 2024-08-21 at 4 27 15 PM

Checklist

@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v8.15.1 labels Aug 21, 2024
@yctercero yctercero self-assigned this Aug 21, 2024
@yctercero yctercero requested a review from a team as a code owner August 21, 2024 21:46
@yctercero yctercero requested a review from e40pud August 21, 2024 21:46
@yctercero yctercero marked this pull request as draft August 21, 2024 22:06
@yctercero
Copy link
Contributor Author

/ci

Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@yctercero yctercero marked this pull request as ready for review August 22, 2024 15:55
@yctercero yctercero enabled auto-merge (squash) August 26, 2024 19:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.0MB 18.0MB +984.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit cbc8f17 into elastic:main Aug 26, 2024
39 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191032

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants