Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Misconfiguration preview & Refactor CSP Plugin to include new package PHASE 1 #190832

Merged

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Aug 20, 2024

Summary

The previous PR was way too big and made it hard to review without missing any bugs or potential bugs, Thus we decided we are going to make series of smaller PR to make things more manageable

We will be splitting it into 4 PR
Phase 1: Creating empty packages for csp and csp-common
Phase 2: Move Types from CSP plugin to the Package + Deleting duplicates in the CSP plugin where possible
Phase 3: Move Functions, Utils or Helpers, Hooks to Package
Phase 4: Misconfiguration Preview feature (with Cypress test and other required test)

This is Phase 1 of the Process

@animehart animehart marked this pull request as ready for review August 20, 2024 16:55
@animehart animehart added the Team:Cloud Security Cloud Security team related label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Aug 20, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@animehart animehart requested a review from a team August 20, 2024 20:21
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for breaking it down into small PRs

@animehart animehart merged commit 77ad05e into elastic:main Aug 20, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants