Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Fix small CrowdStrike connector issues #190689

Merged
merged 6 commits into from
Aug 19, 2024
Merged

[EDR Workflows] Fix small CrowdStrike connector issues #190689

merged 6 commits into from
Aug 19, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Aug 19, 2024 •
edited by kibanamachine
Loading

  • Fixes wrong field used for token
  • Changes field used to get status (based on real data)
  • Improves search to find host name

@tomsonpl tomsonpl self-assigned this Aug 19, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 v8.15.1 labels Aug 19, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl marked this pull request as ready for review August 19, 2024 18:05
@tomsonpl tomsonpl requested a review from a team as a code owner August 19, 2024 18:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl changed the title [EDR Workflows] Fix CrowdStrike auth issue [EDR Workflows] Fix small CrowdStrike connector issues Aug 19, 2024
@tomsonpl tomsonpl enabled auto-merge (squash) August 19, 2024 19:55
@tomsonpl tomsonpl merged commit 9524bbc into elastic:main Aug 19, 2024
40 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2024
@tomsonpl
[EDR Workflows] Fix small CrowdStrike connector issues (elastic#190689)
670c659 
(cherry picked from commit 9524bbc)
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 19, 2024
@kibanamachine @tomsonpl
[8.15] [EDR Workflows] Fix small CrowdStrike connector issues (#190689)…
af5affc 
… (#190746)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[EDR Workflows] Fix small CrowdStrike connector issues
(#190689)](#190689)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"tomasz.ciecierski@elastic.co"},"sourceCommit":{"committedDate":"2024-08-19T21:20:36Z","message":"[EDR
Workflows] Fix small CrowdStrike connector issues
(#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.16.0","v8.15.1"],"title":"[EDR Workflows] Fix small
CrowdStrike connector
issues","number":190689,"url":"https://github.com/elastic/kibana/pull/190689","mergeCommit":{"message":"[EDR
Workflows] Fix small CrowdStrike connector issues
(#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190689","number":190689,"mergeCommit":{"message":"[EDR
Workflows] Fix small CrowdStrike connector issues
(#190689)","sha":"9524bbcdc7ce7750a6e891d5b103a582e07a5772"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzl pzl pzl approved these changes

@szwarckonrad szwarckonrad Awaiting requested review from szwarckonrad szwarckonrad is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

@tomsonpl tomsonpl

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.1 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomsonpl @elasticmachine @kibana-ci @kibanamachine @pzl