Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip search alert tests #190519

Merged
merged 3 commits into from
Aug 20, 2024
Merged

[Discover] Unskip search alert tests #190519

merged 3 commits into from
Aug 20, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Aug 14, 2024
@jughosta jughosta self-assigned this Aug 14, 2024
@jughosta
Copy link
Contributor Author

/ci

@kibanamachine

This comment was marked as outdated.

Sign in to view
@jughosta
Copy link
Contributor Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6790

[✅] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts: 25/25 tests passed.
[✅] x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/config.ts: 25/25 tests passed.

see run history

@jughosta
Copy link
Contributor Author

/ci

@jughosta jughosta marked this pull request as ready for review August 19, 2024 18:05
@jughosta jughosta requested a review from a team as a code owner August 19, 2024 18:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed the flaky test runner, hopefully that's the last we see of it 🤞

@jughosta jughosta merged commit e66098a into elastic:main Aug 20, 2024
20 checks passed
@jughosta jughosta deleted the 190090-unskip-search-source-test branch August 20, 2024 06:56
@wayneseymour wayneseymour mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.16.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @kibanamachine @elasticmachine @kibana-ci @davismcphee