Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Entity details] - move osquery, response and investigation guide related hooks and components to flyout folder #190110

Conversation

PhilippeOberti
Copy link
Contributor

Summary

This PR continues the effort in removing all old flyout components, hooks and utils functions. It moves all the code related to osquery, response and investigation guide from the old event_details folder to the alert details expandable flyout folder

The goal of this PR is to:

  • move the code and update the imports
  • add unit tests if they were not present

The purpose of the PR was never to full refactor the code, so things that aren't necessarily super clean might still be present.

No UI changes should be visible whatsoever!

Checklist

https://github.com/elastic/security-team/issues/7462

@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 labels Aug 8, 2024
@PhilippeOberti PhilippeOberti force-pushed the investigation-guide-response-osquery branch from 0d41feb to e2968d1 Compare August 8, 2024 09:26
@PhilippeOberti PhilippeOberti marked this pull request as ready for review August 8, 2024 10:24
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner August 8, 2024 10:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)


export interface UseOsqueryTabParams {
/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is actually no longer needed as the only place where it was used was removed while i was on vacation


export interface UseResponseActionsViewParams {
/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@PhilippeOberti PhilippeOberti force-pushed the investigation-guide-response-osquery branch from e2968d1 to 5fe97cf Compare August 19, 2024 09:55
…stigation guide related hooks and components to flyout folder
@PhilippeOberti PhilippeOberti force-pushed the investigation-guide-response-osquery branch 4 times, most recently from 652f54c to 9d5a939 Compare August 19, 2024 11:44
@PhilippeOberti PhilippeOberti force-pushed the investigation-guide-response-osquery branch from 9d5a939 to 63d76f1 Compare August 19, 2024 13:07
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5653 5652 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.7MB 20.7MB -6.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 04503bf into elastic:main Aug 19, 2024
41 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants