-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Entity details] - move osquery, response and investigation guide related hooks and components to flyout folder #190110
Conversation
0d41feb
to
e2968d1
Compare
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
||
export interface UseOsqueryTabParams { | ||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is actually no longer needed as the only place where it was used was removed while i was on vacation
|
||
export interface UseResponseActionsViewParams { | ||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
e2968d1
to
5fe97cf
Compare
…stigation guide related hooks and components to flyout folder
652f54c
to
9d5a939
Compare
9d5a939
to
63d76f1
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
This PR continues the effort in removing all old flyout components, hooks and utils functions. It moves all the code related to osquery, response and investigation guide from the old event_details folder to the alert details expandable flyout folder
The goal of this PR is to:
The purpose of the PR was never to full refactor the code, so things that aren't necessarily super clean might still be present.
No UI changes should be visible whatsoever!
Checklist
https://github.com/elastic/security-team/issues/7462