Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS] Simplify server declaration for case APIs #169889

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[OAS] Simplify server declaration for case APIs #169889

merged 1 commit into from
Oct 26, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 25, 2023 •
edited by kibanamachine
Loading

This PR removes localhost from the "servers" property for case OpenAPI specifications. Relates to similar changes being made to all our Kibana OAS.

@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.12.0 labels Oct 25, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl added the Feature:Cases Cases feature label Oct 25, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review October 25, 2023 23:28
@lcawl lcawl requested a review from a team as a code owner October 25, 2023 23:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl merged commit 952de6e into elastic:main Oct 26, 2023
41 checks passed
@lcawl lcawl deleted the case-oas-servers branch October 26, 2023 15:29
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.11:
- [OAS] Custom fields in case APIs (#169327)

Manual backport

To create the backport manually run:

node scripts/backport --pr 169889

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl mentioned this pull request Oct 26, 2023
Merged
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Oct 30, 2023
@lcawl @bryce-b
[OAS] Simplify server declaration for case APIs (elastic#169889)
89a4044
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Oct 31, 2023
@lcawl @awahab07
[OAS] Simplify server declaration for case APIs (elastic#169889)
241e043
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 16, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 169889 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @kibana-ci @elasticmachine @kibanamachine @adcoelho