Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Search Applications - Icons for Document Flyout #153899

Merged

Conversation

sloanelybutsurely
Copy link
Contributor

Summary

  • Updates document flyout to include icon for the field types

image

Checklist

Delete any items that are not applicable to this PR.

@sloanelybutsurely sloanelybutsurely requested a review from a team March 28, 2023 20:32
@sloanelybutsurely sloanelybutsurely added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch labels Mar 28, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2027 2028 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.2MB 2.2MB +637.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloanelybutsurely sloanelybutsurely merged commit ec58ba6 into elastic:main Mar 29, 2023
@sloanelybutsurely sloanelybutsurely deleted the sloane/document-flyout-icons branch March 29, 2023 11:46
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 29, 2023
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2023
…lastic#153899)

## Summary

- Updates document flyout to include icon for the field types

<img width="1308" alt="image"
src="https://user-images.githubusercontent.com/1699281/228359668-aa036249-4f91-4c07-a07d-c0eb0fc8ad91.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants