Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix overview flaky test #137833

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 2, 2022

Summary

Fixes #131346

Finally found a reason

it can be reproduced by adding a delay before the assertion in the test such as

await new Promise((resolve) => setTimeout(resolve, 1000));

@shahzad31 shahzad31 requested a review from a team as a code owner August 2, 2022 12:12
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 changed the title fix overview test [Uptime] Fix overview flaky test Aug 2, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Aug 2, 2022
@shahzad31 shahzad31 enabled auto-merge (squash) August 2, 2022 12:13
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is passing now.

@shahzad31 shahzad31 merged commit 2091184 into elastic:main Aug 2, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 2, 2022
(cherry picked from commit 2091184)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@shahzad31 shahzad31 deleted the fix-overview-test branch September 23, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.4.0 v8.5.0
Projects
None yet
5 participants