[Unified search] Improve the way that spaces are handled on inline mode #137678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:Unified search
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
stratoula
changed the title
stratoula
changed the title
jloleysens
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Code LGTM, great work @stratoula ! Added one refinement let me know what you think!
src/plugins/unified_search/public/query_string_input/text_based_languages_editor/helpers.ts
Outdated
Show resolved
Hide resolved
…d_languages_editor/helpers.ts Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug described here #136950 (comment)
When the user has an SQL query with multilines but the editor is on the inline mode we want to convert the query to oneliner but with one space between the words.
Checklist