Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix data view service permissions #119712

Merged
merged 1 commit into from
Nov 25, 2021
Merged

[ML] Fix data view service permissions #119712

merged 1 commit into from
Nov 25, 2021

Conversation

jgowdyelastic
Copy link
Member

Calls to the data view service should use current user.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 25, 2021
@jgowdyelastic jgowdyelastic self-assigned this Nov 25, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 25, 2021 10:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@peteharverson
Copy link
Contributor

peteharverson commented Nov 25, 2021 •
edited by jgowdyelastic
Loading

There is still an issue with the permission checking when deleting a DFA job I think. For a user with this configured in the role:

image

the option to delete the data view when deleting a job is still shown, and the data view can be deleted:

image

Note this also affects deleting a transform.

#119732 created to fix disabled checkbox

peteharverson
peteharverson approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue around the check on the Delete job / transform controls is unrelated to the change here, so best done in a separate PR. This edit LGTM.

darnautov
darnautov approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 2830056 into elastic:main Nov 25, 2021
@jgowdyelastic jgowdyelastic deleted the fox-data-view-service-permissions branch November 25, 2021 13:35
@kibanamachine kibanamachine mentioned this pull request Nov 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 25, 2021
@jgowdyelastic @kibanamachine
[ML] Fix data view service permissions (elastic#119712)
f65547c
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 25, 2021
@jgowdyelastic @kibanamachine
[ML] Fix data view service permissions (elastic#119712)
f457aad
@kibanamachine kibanamachine mentioned this pull request Nov 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 25, 2021
@kibanamachine @jgowdyelastic
[ML] Fix data view service permissions (#119712) (#119728)
4c73db0 
Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 25, 2021
@kibanamachine @jgowdyelastic
[ML] Fix data view service permissions (#119712) (#119729)
309c071 
Co-authored-by: James Gowdy <jgowdy@elastic.co>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@jgowdyelastic @TinLe
[ML] Fix data view service permissions (elastic#119712)
3bc2233
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@jgowdyelastic @gbamparop
[ML] Fix data view service permissions (elastic#119712)
c9cb117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @peteharverson @kibanamachine @darnautov