Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Removing focusable element in tags badge #118062

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Nov 9, 2021

Resolves #117334

Summary

As shown in the issue, tags had 2 focusable elements. Updated so it now only has 1 focusable element:
Nov-09-2021 13-04-02

@ymao1 ymao1 changed the title Removing focusable element in tags badge [Alerting UI] Removing focusable element in tags badge Nov 9, 2021
@ymao1 ymao1 self-assigned this Nov 9, 2021
@ymao1 ymao1 added Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0 v8.1.0 labels Nov 9, 2021
@ymao1 ymao1 marked this pull request as ready for review November 9, 2021 18:47
@ymao1 ymao1 requested a review from a team as a code owner November 9, 2021 18:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 777.4KB 777.4KB +12.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 10, 2021
@ymao1 ymao1 merged commit 6b81454 into elastic:main Nov 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 10, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 10, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 10, 2021
Co-authored-by: ymao1 <ying.mao@elastic.co>
kibanamachine added a commit that referenced this pull request Nov 10, 2021
Co-authored-by: ymao1 <ying.mao@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
@ymao1 ymao1 deleted the alerting/tags-focus branch January 27, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rules and Connectors] Tags badge in the rules list has 2 focusable elements
5 participants