Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Disabling create data view for data frame analytics and transforms wizards #117690

Conversation

jgowdyelastic
Copy link
Member

If the user does not have permission to create index patterns, we should disable the option in the UI.

Relates to similar PR #117347

Transforms

image

Data frame analytics

image

@jgowdyelastic jgowdyelastic added release_note:fix :ml v8.0.0 Feature:Transforms ML transforms Feature:Data Frame Analytics ML data frame analytics features auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 5, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 5, 2021 16:28
@jgowdyelastic jgowdyelastic self-assigned this Nov 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but would be good to add the check into the DFA results exploration page too.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes for DFA results exploration page, and LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +1.0KB
transform 327.2KB 327.5KB +376.0B
total +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
@jgowdyelastic jgowdyelastic merged commit f2872d8 into elastic:main Nov 15, 2021
@jgowdyelastic jgowdyelastic deleted the disabling-create-data-view-for-dfa-and-transforms branch November 15, 2021 08:40
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 15, 2021
…ms wizards (elastic#117690)

* [ML] Disabling create data view for data frame analytics and transforms wizards

* removing dfa results link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 15, 2021
…ms wizards (#117690) (#118502)

* [ML] Disabling create data view for data frame analytics and transforms wizards

* removing dfa results link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: James Gowdy <jgowdy@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
…ms wizards (elastic#117690)

* [ML] Disabling create data view for data frame analytics and transforms wizards

* removing dfa results link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
…ms wizards (#117690)

* [ML] Disabling create data view for data frame analytics and transforms wizards

* removing dfa results link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
…ms wizards (elastic#117690)

* [ML] Disabling create data view for data frame analytics and transforms wizards

* removing dfa results link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Frame Analytics ML data frame analytics features Feature:Transforms ML transforms :ml release_note:fix v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants