-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exploatory view] Fix duplicate breakdowns #117304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had actually discussed a while back with @drewpost and @liciavale not using the series name for the breakdown labels, because then you lose context of the actual metric type. What do you think @drewpost @liciavale? What would you prefer?
I'm not sure I remember that conversation. (entirely possible with my Swiss Cheese brain). The preferred behaviour is that the legend matches the series name |
@drewpost The problem I see is that, for the chart itself, there is no longer any context of the data type for series. When isolating the chart away from the series, you can see the issue Of course, you can see the metric type when referring back to the corresponding series. Happy to implement it either way, just raising my concerns. |
@dominiqueclarke my suggestion would be to include metric instead of data type in default naming, like instead of saying ux-series, we could say page-views series, and at that point it's up to the user to come up with a better name. WDYT? |
@elasticmachine merge upstream |
We could also append the metric, like say I think it could be nice to also have the data type in the default name, but then with longer names it's more possible to get cut off. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly reminder: Looks like this PR hasn’t been backported yet. |
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Fixes #117032
Remove breakdown from clones series, when user tries to copy a series
After:
Before: