Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exploatory view] Fix duplicate breakdowns #117304

Merged
merged 7 commits into from
Nov 10, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 3, 2021

Summary

Fixes #117032

Remove breakdown from clones series, when user tries to copy a series

After:

image

Before:
image

@shahzad31 shahzad31 marked this pull request as ready for review November 3, 2021 13:08
@shahzad31 shahzad31 requested a review from a team as a code owner November 3, 2021 13:08
@shahzad31 shahzad31 self-assigned this Nov 3, 2021
@shahzad31 shahzad31 added v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 3, 2021
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had actually discussed a while back with @drewpost and @liciavale not using the series name for the breakdown labels, because then you lose context of the actual metric type. What do you think @drewpost @liciavale? What would you prefer?

@drewpost
Copy link

drewpost commented Nov 3, 2021

I'm not sure I remember that conversation. (entirely possible with my Swiss Cheese brain). The preferred behaviour is that the legend matches the series name

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Nov 3, 2021

I'm not sure I remember that conversation. (entirely possible with my Swiss Cheese brain). The preferred behaviour is that the legend matches the series name

@drewpost The problem I see is that, for the chart itself, there is no longer any context of the data type for series. When isolating the chart away from the series, you can see the issue

Screen Shot 2021-11-03 at 3 59 47 PM

Of course, you can see the metric type when referring back to the corresponding series.

Happy to implement it either way, just raising my concerns.

@shahzad31
Copy link
Contributor Author

I'm not sure I remember that conversation. (entirely possible with my Swiss Cheese brain). The preferred behaviour is that the legend matches the series name

@drewpost The problem I see is that, for the chart itself, there is no longer any context of the data type for series. When isolating the chart away from the series, you can see the issue

Screen Shot 2021-11-03 at 3 59 47 PM

Of course, you can see the metric type when referring back to the corresponding series.

Happy to implement it either way, just raising my concerns.

@dominiqueclarke my suggestion would be to include metric instead of data type in default naming, like instead of saying ux-series, we could say page-views series, and at that point it's up to the user to come up with a better name. WDYT?

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Nov 5, 2021

I'm not sure I remember that conversation. (entirely possible with my Swiss Cheese brain). The preferred behaviour is that the legend matches the series name

@drewpost The problem I see is that, for the chart itself, there is no longer any context of the data type for series. When isolating the chart away from the series, you can see the issue
Screen Shot 2021-11-03 at 3 59 47 PM
Of course, you can see the metric type when referring back to the corresponding series.
Happy to implement it either way, just raising my concerns.

@dominiqueclarke my suggestion would be to include metric instead of data type in default naming, like instead of saying ux-series, we could say page-views series, and at that point it's up to the user to come up with a better name. WDYT?

We could also append the metric, like say ux-series-page-views/ux-series-2-page-views. Or page-views-ux-series.

I think it could be nice to also have the data type in the default name, but then with longer names it's more possible to get cut off.

@shahzad31 shahzad31 changed the title [Exploatory view] Fix labels and duplicate breakdowns [Exploatory view] Fix duplicate breakdowns Nov 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 378.7KB 378.8KB +17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one breakdown being applied at a time when series is copied.

Screen Shot 2021-11-09 at 3 35 10 PM

@shahzad31 shahzad31 merged commit 89f9c8f into elastic:main Nov 10, 2021
@shahzad31 shahzad31 deleted the fix-duplicate-breakdowns branch November 10, 2021 10:00
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117304 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 12, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 12, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 12, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2021
kibanamachine added a commit that referenced this pull request Nov 12, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] [Exploratory View] Multi series can have multi breakdowns when series are copied
4 participants