Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] EUI token use FormattedMessage instead of i18n.translate: the sequel #107080

Merged
merged 2 commits into from
Jul 29, 2021
Merged

[i18n] EUI token use FormattedMessage instead of i18n.translate: the sequel #107080

merged 2 commits into from
Jul 29, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 28, 2021 •
edited
Loading

Summary

Reinstates the changes made in #105841, which were undone in a collision with #106377.
From the original PR:

Updates an i18n token added in #105127 to use FormattedMessage instead of i18n.translate. The pagination numbers are React components, not strings, and were therefore rendering as [object Object].

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.15.0 labels Jul 28, 2021
@thompsongl thompsongl requested review from smith and Bamieh July 28, 2021 19:58
@thompsongl thompsongl requested review from a team as code owners July 28, 2021 19:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 421.4KB 421.5KB +59.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit c2cb189 into elastic:master Jul 29, 2021
@thompsongl thompsongl mentioned this pull request Jul 29, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jul 29, 2021
@thompsongl @kibanamachine
reinstate elastic#105841 (elastic#107080)
21fba00 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
thompsongl added a commit that referenced this pull request Jul 29, 2021
@thompsongl @kibanamachine
reinstate #105841 (#107080) (#107207)
ebc4ce5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@thompsongl @kibanamachine @vadimkibana
reinstate elastic#105841 (elastic#107080)
0b6e47b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thompsongl @elasticmachine @kibanamachine @smith @Bamieh