[Uptime] Step Details Page navigation - handle unequal steps between check groups #106289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
approved these changes
Jul 20, 2021
|
|
||
| const step = steps.find((stepF) => stepF.synthetics?.step?.index !== expandedRowKey)!; |
|
|
||
| // expect only one accordion to be expanded | ||
| expect(Object.keys(result.current.expandedRows)).toEqual(['0']); | ||
| }); |
There was a problem hiding this comment.
Great job on this test 👍
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 20, 2021
…tails page in Uptime (elastic#106289)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 20, 2021
…tails page in Uptime (elastic#106289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106248
When navigating between different checks on the step details page, we attempt to preserve the state of the accordion, keeping the appropriate accordion open as the user navigates. This can cause issues when there is an unequal amount of steps between each check, causing an unhandled reference error.
This PR adds additional defense to prevent this error.
Steps for testing: