Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fixes cypress flake across two tests (#105645) #105700

Closed

Conversation

FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.x:

## Summary

* Fixes flake where it looks like pre-built rules can take longer than 1 minute to load, so I increased that to 5 minutes
* There are problems with how the `cy.intercept` is not always working on CI we don't understand yet, so I am removing the failing call but keeping the rest of the test for the failure.

Backporting these two into `7.14` to add stability to `7.14` tests as well.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@FrankHassanabad FrankHassanabad enabled auto-merge (squash) July 14, 2021 23:59
@FrankHassanabad FrankHassanabad self-assigned this Jul 15, 2021
@FrankHassanabad
Copy link
Contributor Author

@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad enabled auto-merge (squash) July 15, 2021 17:30
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad
Copy link
Contributor Author

Root cause was found and merged from here (we don't need this cleanup one anymore):
#105790

@FrankHassanabad FrankHassanabad deleted the backport/7.x/pr-105645 branch July 15, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants