Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions] Fixes cypress flake across two tests seen happening on PR's #105645

Merged
merged 2 commits into from
Jul 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,26 +20,6 @@ import { populateTimeline } from '../../tasks/timeline';

import { HOSTS_URL } from '../../urls/navigation';

const RowRenderersId = [
'alerts',
'auditd',
'auditd_file',
'library',
'netflow',
'plain',
'registry',
'suricata',
'system',
'system_dns',
'system_endgame_process',
'system_file',
'system_fim',
'system_security_event',
'system_socket',
'threat_match',
'zeek',
];

describe('Row renderers', () => {
beforeEach(() => {
cleanKibana();
Expand Down Expand Up @@ -100,9 +80,5 @@ describe('Row renderers', () => {
.should('not.be.checked');

cy.wait('@updateTimeline').its('response.statusCode').should('eq', 200);

cy.wait('@updateTimeline').then((interception) => {
expect(interception.request.body.timeline.excludedRowRendererIds).to.eql(RowRenderersId);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ export const sortByActivatedRules = () => {

export const waitForRulesTableToBeLoaded = () => {
cy.get(RULES_TABLE_INITIAL_LOADING_INDICATOR).should('exist');
cy.get(RULES_TABLE_INITIAL_LOADING_INDICATOR).should('not.exist');
// Wait up to 5 minutes for the rules to load as in CI containers this can be very slow
cy.get(RULES_TABLE_INITIAL_LOADING_INDICATOR, { timeout: 300000 }).should('not.exist');
};

export const waitForRulesTableToBeRefreshed = () => {
Expand Down