Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] APM Latency Correlations (#99905) #103745

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* [ML] Async Search Service.

* [ML] Log Log Area Charts Grid. Scatterplot with streaming data.

* [ML] Remove scatterplot streaming demo.

* [ML] Improved histogram bins for log scale.

* [ML] Move client side code from Ml to APM plugin.

* [ML] Adds correlation table.

* [ML] Layout tweaks.

* [ML] Move server side code from ML to APM.

* [ML] Remove console.logs.

* [ML] Fix types.

* [ML] Chart area line type fix. Slowness %.

* [ML] Comment unused vars.

* Fix missing pluginsStart data in context

* Add KS test value and rename table columns

* Update percentiles to be correct

* Make columns optional

* Update fractionals/expectations to match with backend logic

* Update so progress is 100% when all is completed

* Make pre-processing steps smaller part of overall progress(to show charts earlier)

* Add no correlations found message

* Fix progress logic

* Fix incorrect threshold, types

* Add back APM filtering functionality to match with other table

* Improve histogram equality check with random sampling

* Show overall latency distribution right away

* Rename demo tab to latencyCorrelationsTab

* Update percentiles query to use hdr

* [ML] Fix issue where apm-* might have multiple indices with different mappings where keyword is not the only type

- Fix to check for keyword mapping more thoroughly
- Add try catch if one of the es search fail, don't quit the entire fetch

* Remove commented code

* Remove kstest column, round correlation to 2 sigfig dec

* Remove old latency tab, replace with ml latency correlations tab as first/default one

* Set axis to start at 0 because agg may results in weird

* Remove commented code for grouping duplicates

* Update msg to mean significant correlations

* Add i18n

* Change correlations flyout back to medium size

* Add name of service or transaction for clarity

* Share i18n

* Consolidate roundToDecimalPlace usage

* Remove redundant isDuplicate

* Create MAX_CORRELATIONS_TO_SHOW

* Update mlCorrelationcolumns

* Fix i18n quotations

* Update query to include filter

* Revert "Update query to include filter"

This reverts commit 9a37eec

* Rename MlCorrelations to MlLatencyCorrelations for clarity

* Add pagination

* Update include/exclude logic for field candidates and add ip field support

* Add transactionName filter suport

* Reorganize math utils

* Group duplicates together

* Fix typescript, better hasPrefixToInclude support check,

* Remove Finished toast

* Add title to y axis

* Reduce number of tick labels to show

* Highlight table row that is being used for graph

* Add from to follow MDN guideline

* Add APM style prefix

* Fix i18n

* [ML] Fix logic for tick format to only show power of 10

* Replace roundToDecimalPlace with asPreciseDecimal

* Switch to lodash range

* Clean up get_query_with_params

* Prioritize candidates using field_terms

* Update percentiles result type to be array instead of objects

* Use observability's rangeQuery instead

* Change arg format of query

* Revert candidate_terms logic

* Consolidate fractions, expectations, and ranges calc

* Add tooltip for Correlation

* Change terms size to 20

* Move env/service/transaction sticky header to top level, remove link

* Add support for http.response.status_code

* Replace histogram circular markers with bars

* Delete unused roundToDecimalPlace

* Add fractions calculation

* Make notes of fractions and fix bucket correlation

* Remove any, commented code, consolidate cancelFetch

* Use es6 max

* Align tooltip at the top

* Get rid of getCoreServices, param docs, rename type, remove rangeQuery

* Adjust range

* Show all values without grouping duplicates

* Fix pagination

* Make flyout larger

Co-authored-by: Quynh Nguyen <quynh.nguyen@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1557 1559 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +12.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@qn895
Copy link
Member

qn895 commented Jun 29, 2021

@elasticmachine run elasticsearch-ci/docs

@kibanamachine kibanamachine merged commit f94c42e into elastic:7.x Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants