Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip and improve empty results query functional test #102995

Merged
merged 3 commits into from
Jun 23, 2021
Merged

[Discover] Unskip and improve empty results query functional test #102995

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e2ce5a
Harden and unskip empty results query functional test
kertal Jun 22, 2021
47205b4
Update _discover.ts
kertal Jun 23, 2021
447aaa1
Merge branch 'master' into kertal-pr-2021-06-22-fix-functional-no-result
kibanamachine Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/functional/apps/discover/_discover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/89550
describe.skip('query #2, which has an empty time range', () => {
describe('query #2, which has an empty time range', () => {
const fromTime = 'Jun 11, 1999 @ 09:22:11.000';
const toTime = 'Jun 12, 1999 @ 11:21:04.000';

Expand All @@ -193,8 +192,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('should show "no results"', async () => {
const isVisible = await PageObjects.discover.hasNoResults();
expect(isVisible).to.be(true);
await retry.waitFor('No results screen is displayed', async function () {
kertal marked this conversation as resolved.
Show resolved Hide resolved
const isVisible = await PageObjects.discover.hasNoResults();
return isVisible === true;
});
});

it('should suggest a new time range is picked', async () => {
Expand Down