Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Change "View full trace" button fill #102066

Merged
merged 1 commit into from
Jun 14, 2021
Merged

[APM] Change "View full trace" button fill #102066

merged 1 commit into from
Jun 14, 2021

Conversation

formgeist
Copy link
Contributor

Summary

Closes #95398

Changed the button fill since the new theme has some improvements to the default button style.

Before

Screenshot 2021-06-14 at 15 42 08

After

Screenshot 2021-06-14 at 15 33 16

@formgeist formgeist added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed amsterdam labels Jun 14, 2021
@formgeist formgeist self-assigned this Jun 14, 2021
@formgeist formgeist requested a review from a team as a code owner June 14, 2021 13:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist changed the title [APM] Change View full trace button fill [APM] Change "View full trace" button fill Jun 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +24.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @formgeist

@formgeist formgeist merged commit 767b67d into elastic:master Jun 14, 2021
@formgeist formgeist deleted the apm-change-view-full-trace-button-fill branch June 14, 2021 16:50
@kibanamachine kibanamachine mentioned this pull request Jun 14, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2021
@formgeist @kibanamachine
[APM] Change View full trace button fill (elastic#102066)
c39a9ff
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 14, 2021
@kibanamachine @formgeist
[APM] Change View full trace button fill (#102066) (#102098)
7d31209 
Co-authored-by: Casper Hübertz <casper@elastic.co>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@formgeist
[APM] Change View full trace button fill (elastic#102066)
9114e2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@formgeist formgeist

Labels
amsterdam auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Trace sample view: Change the button fill style of the "View full trace" button
4 participants
@formgeist @elasticmachine @kibanamachine @sorenlouv