Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Url service locators (#101045) #101473

Merged
merged 1 commit into from
Jun 7, 2021
Merged

[7.x] Url service locators (#101045) #101473

merged 1 commit into from
Jun 7, 2021

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

@streamich @kibanamachine
Url service locators (#101045)
18df284 
* feat: 🎸 add url service types

* refactor: 💡 move locator types into its own folder

* feat: 🎸 add abstract locator implementation

* feat: 🎸 implement abstract locator client

* feat: 🎸 add browser-side locators service

* feat: 🎸 implement locator .getLocation()

* feat: 🎸 implement navigate function

* feat: 🎸 implement locator service in /common folder

* feat: 🎸 expose locators client on browser and server

* refactor: 💡 make locators async

* chore: 🤖 add deprecation notice to URL generators

* docs: ✏️ add deprecation notice to readme

* test: 💍 make test locator async

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@streamich streamich enabled auto-merge (squash) June 7, 2021 11:19
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
share 47 53 +6

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
share 67.9KB 71.3KB +3.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit ae2fe27 into elastic:7.x Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streamich @kibanamachine