From 720d7a64b56ea4f0b1f6b5038a5532cf61404e0a Mon Sep 17 00:00:00 2001 From: dej611 Date: Fri, 4 Jun 2021 12:18:59 +0200 Subject: [PATCH 01/11] :memo: Add some continuity explanation --- .../coloring/palette_configuration.tsx | 21 ++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx index df01b3e57cd7df..ca561c67010822 100644 --- a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx +++ b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx @@ -115,9 +115,24 @@ export function CustomizablePalette({ /> + {i18n.translate('xpack.lens.table.dynamicColoring.continuity.label', { + defaultMessage: 'Color continuity', + })}{' '} + + + } display="rowCompressed" > Date: Fri, 4 Jun 2021 12:38:20 +0200 Subject: [PATCH 02/11] :memo: Add some faq about dynamic coloring --- docs/user/dashboard/lens.asciidoc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index c5718b2a089bfc..48a66f75cd94d6 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -303,3 +303,22 @@ Pagination in a data table is unsupported in *Lens*. However, the < Date: Fri, 4 Jun 2021 12:48:15 +0200 Subject: [PATCH 03/11] :memo: revisit copy --- .../public/shared_components/coloring/palette_configuration.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx index ca561c67010822..d8c4a98fe5ea79 100644 --- a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx +++ b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx @@ -125,7 +125,7 @@ export function CustomizablePalette({ 'xpack.lens.table.dynamicColoring.customPalette.continuityHelp', { defaultMessage: - 'Decide how colors extends before or after the defined color stops.', + 'Decide how colors should behave before the first color stop and after the last one.', } )} position="top" From 4b3f4d9d42a0ec4eb9f93dadcc0e4480727fe4c8 Mon Sep 17 00:00:00 2001 From: dej611 Date: Mon, 7 Jun 2021 14:51:46 +0200 Subject: [PATCH 04/11] :ok_hand: Rename question --- docs/user/dashboard/lens.asciidoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index 94c6f5b354aeae..1d3f3304fc86a9 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -305,8 +305,8 @@ Pagination in a data table is unsupported in *Lens*. However, the < Date: Tue, 15 Jun 2021 10:35:28 +0200 Subject: [PATCH 05/11] Update docs/user/dashboard/lens.asciidoc Co-authored-by: Kaarina Tungseth --- docs/user/dashboard/lens.asciidoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index 1d3f3304fc86a9..0438483b67801f 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -308,7 +308,7 @@ Pagination in a data table is unsupported in *Lens*. However, the < Date: Tue, 15 Jun 2021 10:35:35 +0200 Subject: [PATCH 06/11] Update docs/user/dashboard/lens.asciidoc Co-authored-by: Kaarina Tungseth --- docs/user/dashboard/lens.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index 0438483b67801f..ca97d28f132155 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -311,7 +311,7 @@ Pagination in a data table is unsupported in *Lens*. However, the < Date: Tue, 15 Jun 2021 10:36:55 +0200 Subject: [PATCH 07/11] Update docs/user/dashboard/lens.asciidoc Co-authored-by: Kaarina Tungseth --- docs/user/dashboard/lens.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index ca97d28f132155..aee053b60f590a 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -313,7 +313,7 @@ There could be various reasons for a specific value in the table to have a diffe Here's a short list of few different aspects to check: * Make sure the value falls within the desired color stop value defined in the panel. Color stop values are "inclusive". -* Make sure to have the right value precision setup: value formatters could round up or down numeric values. +* Make sure you have the right value precision setup: value formatters could round the numeric values up or down. * Make sure the right color continuity option is selected: if the number is below the first color stop value a continuity of type `Below` or `Above and below range` is required From a594405eda47d1ef12e19dfa485053179adbcbe5 Mon Sep 17 00:00:00 2001 From: Marco Liberati Date: Tue, 15 Jun 2021 10:37:03 +0200 Subject: [PATCH 08/11] Update docs/user/dashboard/lens.asciidoc Co-authored-by: Kaarina Tungseth --- docs/user/dashboard/lens.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index aee053b60f590a..1d109547c97685 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -317,7 +317,7 @@ Here's a short list of few different aspects to check: * Make sure the right color continuity option is selected: if the number is below the first color stop value a continuity of type `Below` or `Above and below range` is required -* The values set by default by the Value type are based on the current data range displayed on the data table. +* The default values set by the Value type are based on the current data range displayed on the data table. ** If a `Number` custom configuration is used, check the color stops value are covering the current data range. From 08414b95744160ab8d3f1f131fd2a7fb84d1d7ce Mon Sep 17 00:00:00 2001 From: Marco Liberati Date: Tue, 15 Jun 2021 10:37:20 +0200 Subject: [PATCH 09/11] Update docs/user/dashboard/lens.asciidoc Co-authored-by: Kaarina Tungseth --- docs/user/dashboard/lens.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index 1d109547c97685..653d68032d750d 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -319,6 +319,6 @@ Here's a short list of few different aspects to check: * The default values set by the Value type are based on the current data range displayed on the data table. -** If a `Number` custom configuration is used, check the color stops value are covering the current data range. +** If a custom `Number` configuration is used, check that the color stop values are covering the current data range. ** If a `Percent` configuration is used, when the data range changes this has an effect on colors displayed. From 0359ab31d6236ba4e1a628f1c8e446edb185317f Mon Sep 17 00:00:00 2001 From: Marco Liberati Date: Tue, 15 Jun 2021 10:37:32 +0200 Subject: [PATCH 10/11] Update x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx Co-authored-by: Kaarina Tungseth --- .../public/shared_components/coloring/palette_configuration.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx index d8c4a98fe5ea79..f71bda986a8bba 100644 --- a/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx +++ b/x-pack/plugins/lens/public/shared_components/coloring/palette_configuration.tsx @@ -125,7 +125,7 @@ export function CustomizablePalette({ 'xpack.lens.table.dynamicColoring.customPalette.continuityHelp', { defaultMessage: - 'Decide how colors should behave before the first color stop and after the last one.', + 'Specify how colors appear before the first color stop, and after the last color stop.', } )} position="top" From f27c3f26d06c943f8ac5e2404b351b2f4e7da674 Mon Sep 17 00:00:00 2001 From: dej611 Date: Tue, 15 Jun 2021 12:44:58 +0200 Subject: [PATCH 11/11] :ok_hand: Integrated feedback --- docs/user/dashboard/lens.asciidoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/user/dashboard/lens.asciidoc b/docs/user/dashboard/lens.asciidoc index 7cafeca52bdb3c..fb6696d3d8129b 100644 --- a/docs/user/dashboard/lens.asciidoc +++ b/docs/user/dashboard/lens.asciidoc @@ -315,8 +315,8 @@ Pagination in a data table is unsupported in *Lens*. However, the <