Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] [Dashboard] Unsaved Changes Showing After Cancel #96510

Closed
ThomThomson opened this issue Apr 7, 2021 · 3 comments
Closed

[Maps] [Dashboard] Unsaved Changes Showing After Cancel #96510

ThomThomson opened this issue Apr 7, 2021 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Kibana version: 7.12

Describe the bug:
On a dashboard with at least one map panel, if the user navigates to any editor and back again, (without adding anything) the unsaved changes badge will show, and there will be unsaved changes registered for that dashboard on the listing page.

Steps to reproduce:

  1. Open a dashboard with at least one map panel
  2. Navigate to any editor like Lens or Visualize
  3. Click the cancel button or the the browser back button

Expected behavior:
Canceling out of an editor or navigating back should only show unsaved changes if there are actually unsaved changes.

Any additional context:
Looks like the diff is finding differences in the embeddableConfig of the map panel. Some of the information may be getting lost on subsequent loads?

What's interesting is that this doesn't result in any visible changes on the map. The zoom stays as configured etc.

Last Saved Map Panel State:
Screen Shot 2021-04-07 at 5 26 41 PM

Current Map Panel State:
Screen Shot 2021-04-07 at 5 26 26 PM

@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Apr 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Apr 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@ThomThomson
Copy link
Contributor Author

While #98180 is still a problem, the specific issue raised here, where the map buffer causes unsaved changes sometimes, the issue isn't present anymore after simply going to an editor and back. Closing this, but will leave the other issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants