Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify add sample data page object to verify that data actually got installed #91000

Open
bhavyarm opened this issue Feb 10, 2021 · 6 comments
Open
Labels
Team:QA Team label for QA Team

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.0.0

Describe the bug:
This method needs to check that sample data actually got installed:

  async addSampleDataSet(id: string) {
      const isInstalled = await this.isSampleDataSetInstalled(id);
      if (!isInstalled) {
        await testSubjects.click(`addSampleDataSet${id}`);
        await this._waitForSampleDataLoadingAction(id);
      }
    }

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:QA Team label for QA Team and removed bug Fixes for quality problems that affect the customer experience labels Feb 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm
Copy link
Contributor Author

cc @flash1293 if you have thoughts on this. Thanks!

@flash1293
Copy link
Contributor

If the http request installing sample data fails, an error toast is shown, so we could check for that. However, I'm not sure whether the request actually fails - maybe the Kibana server thinks everything's fine, but the data is not actually available in Elasticsearch.

@bhavyarm
Copy link
Contributor Author

cc @dmlemeshko

@dmlemeshko
Copy link
Member

dmlemeshko commented Feb 15, 2021

I'm thinking if we should use API call to load sample data for the cases when we don't test loading as functionality. Request will go ok even if data already loaded. We just need to figure it out how to proceed, e.g. new service for API calls?

Relying on UI sounds like an overhead and not a reliable solution since we came to this issue.

@bhavyarm
Copy link
Contributor Author

This issue came up because of this test failure - #82226. We are testing the UI Part where we install sample data. and in the after method we are removing the installed sample data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:QA Team label for QA Team
Projects
None yet
Development

No branches or pull requests

4 participants