Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Alias "old" metrics fields to "new" metrics fields #87508

Closed
simianhacker opened this issue Jan 6, 2021 · 8 comments
Closed

[Metrics UI] Alias "old" metrics fields to "new" metrics fields #87508

simianhacker opened this issue Jan 6, 2021 · 8 comments
Assignees
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@simianhacker
Copy link
Member

simianhacker commented Jan 6, 2021

We would like to migrate to the new ECS fields that ship with Metricbeat 7.10+. We need to look into creating aliases from the old fields to the new fields for older 7.x indices. There are some caveats with the new fields because some of the data types have changed. For example, the new network field is a delta of the bytes (or the total bytes sent between collection intervals) as opposed to counters (which are the total sum of bytes over the lifetime or the interface).

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kaiyan-sheng
Copy link
Contributor

Thank you @simianhacker! These fields are not in ECS yet and here are the lists of fields for each infrastructure:

@jasonrhodes
Copy link
Member

I'm not sure if I fully understand the plan here for how to best handle this. @simianhacker we should probably revisit this at some point soon and think through what makes sense. @kaiyan-sheng what's the latest status on these field sets?

@kaiyan-sheng
Copy link
Contributor

Hi @jasonrhodes @simianhacker, new host metric fields just released as GA in ECS 1.10.0. These host fields are adopted by modules in Metricbeat as well.

@jasonrhodes
Copy link
Member

@kaiyan-sheng sorry if you've been over this before but I'm trying to remember: are the old fields no longer there at all in later versions of Metricbeat modules, or do they write to both fields, or do we have aliases in place or anything like that? I'm trying to understand if the UI is going to suddenly look like it's missing data if we don't read from the right fields based on the version, which I don't think we are currently doing.

@kaiyan-sheng
Copy link
Contributor

@jasonrhodes Sorry I just saw your question... We are reporting both old and new fields right now. The plan is to remove the old fields in 8.0.

@smith
Copy link
Contributor

smith commented Feb 27, 2023

Not sure what, if anything happened here. Closing.

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@jasonrhodes
Copy link
Member

@smith I believe the current state is that the UI, at times, accounts for the existence of the old and new field names (and must deal with them differently as they are different values entirely). If Metricbeat/Agent + integrations no longer report the "old" fields, I believe a significant chunk of tech debt fork code could be removed in some places in the Metrics UI.

@neptunian could probably confirm whether this is still the case in the UI code, if we care.

@zube zube bot closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants