Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[index patterns] Eliminate direct access to index pattern saved objects #84723

Closed
mattkime opened this issue Dec 2, 2020 · 2 comments
Closed

[index patterns] Eliminate direct access to index pattern saved objects #84723

mattkime opened this issue Dec 2, 2020 · 2 comments
Assignees
@mattkime
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort v7.12.0 v8.0.0

Comments

@mattkime
Copy link
Contributor

mattkime commented Dec 2, 2020

Meta ticket to eliminate (or at least greatly reduce) direct access to index pattern saved objects. Requests should be made through the index pattern service instead. This is likely to hit a lot of code across kibana so we should ask responsible teams to pitch in.

Related to / larger in scope than #84352

DEFINITION IN PROGRESS

  • src/fixtures/logstash_fields.js defines fields that are accessed via saved object. The tests that rely on this need to use a different mock
@mattkime mattkime added chore Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 Team:AppServices v7.12.0 labels Dec 2, 2020
@mattkime mattkime self-assigned this Dec 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Apr 26, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 6, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels May 13, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Jul 6, 2021

closing in favor of #91715

@mattkime mattkime closed this as completed Jul 6, 2021
@mattkime mattkime reopened this Jul 6, 2021
@mattkime mattkime closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattkime @ppisljar @elasticmachine @petrklapka