Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] 8.0 breaking changes #83256

Closed
2 of 4 tasks
sorenlouv opened this issue Nov 12, 2020 · 9 comments
Closed
2 of 4 tasks

[APM] 8.0 breaking changes #83256

sorenlouv opened this issue Nov 12, 2020 · 9 comments

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Nov 12, 2020

TODO: Make list of breaking changes in apm ui, and whether they should be migrated via the upgrade assistant.

Decided

Up for discussion
These can be tabled for now:

@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar
Copy link
Member

dgieselaar commented Dec 7, 2020

Some other fields we should consider making required:

  • span.subtype (used in breakdown data)
  • transaction.result (used in transaction result charts)
  • service.node.name (used for system metrics)

Simply put, we should look into making all fields that we aggregate on via a terms or composite aggregation required, as using missing or missing_bucket means that we miss out on specific ES optimisations.

@sorenlouv
Copy link
Member Author

Thanks @dgieselaar. I'll talk to the server team about this.

@dgieselaar
Copy link
Member

Controversial, but we might want to consider to require one and only one environment per service. Supporting multiple environments per service makes both our application code and our UX more complicated. The workaround is adding the environment of a service in a title which seems acceptable (to me).

@formgeist
Copy link
Contributor

@dgieselaar Understood that it has created way more complexity in our application code than probably necessary, but I think that mostly stems from not having a default environment to begin with. IMO if we remove the ability to separate environment data but group under the same service name, there's no need for environments in the first place (also controversial). Users will be instructed to separate by name easing the burden of maintaining environment names and for us the complexity of service name, transaction type, and environment combinations. Alternatively, we could consider only supporting a set of environment names (production, default, dev, and staging) to make it easier to users to ensure consistency but have enough flexibility to separate their service data per environment.

@dgieselaar
Copy link
Member

If we don't use environment to separate data (ie, remove the environment filter entirely) that's even better. The user can still use custom visualisations that do separate by service.environment.

@dgieselaar
Copy link
Member

@dgieselaar
Copy link
Member

@alisonelizabeth
Copy link
Contributor

Hi 👋! I wanted to point out that there is now a deprecations service (#94845) provided by core to register deprecations within Kibana. All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants