Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid redundant saved objects authorization checks #82203

Closed
jportner opened this issue Oct 30, 2020 · 1 comment · Fixed by #82204
Closed

Avoid redundant saved objects authorization checks #82203

jportner opened this issue Oct 30, 2020 · 1 comment · Fixed by #82204
Assignees
@jportner
Labels
Feature:Saved Objects performance Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

As of Kibana 7.9 (via #67644), saved objects all have a namespaces response field. This is redacted to remove any space IDs that the user is not authorized to see.

Unfortunately, these additional authorization checks can add up very quickly and clog up the audit logs. Instead, we should avoid authorization checks for space IDs that we have already checked during that request.
@jportner jportner added enhancement New value added to drive a business result Feature:Saved Objects labels Oct 30, 2020
@jportner jportner self-assigned this Oct 30, 2020
@jportner jportner mentioned this issue Oct 30, 2020
Merged
@jportner jportner added performance Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! and removed enhancement New value added to drive a business result labels Oct 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jportner jportner

Labels
Feature:Saved Objects performance Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce saved objects authorization checks jportner/kibana
2 participants
@jportner @elasticmachine