Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add TS project references for plugins #82194

Closed
thomasneirynck opened this issue Oct 30, 2020 · 7 comments · Fixed by #89439
Closed

[Maps] Add TS project references for plugins #82194

thomasneirynck opened this issue Oct 30, 2020 · 7 comments · Fixed by #89439
Assignees
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

Add TS project references for the Maps-owned plugins.

See #80508

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Oct 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor Author

This is currently blocked by not all dependencies having their ts-project files defined. notably data and chart plugins for now.

@thomasneirynck
Copy link
Contributor Author

there's an implicit circular dependency between maps_legacy and tile_map/region_map.

e.g.:

@thomasneirynck thomasneirynck self-assigned this Jan 26, 2021
@thomasneirynck
Copy link
Contributor Author

this is blocking APM: #80508 (comment)

@flash1293
Copy link
Contributor

No pressure, but this is also blocking the last Kibana App plugin vis_type_vega as it depends on maps_legacy

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Jan 26, 2021

thx @flash1293 for heads-up, we discussed with @alexwizp and @VladLasitsa. Maps-team will take on the removal of maps_legacy dependency in vis_type_vega, after #88605 has cleared.

@nreese
Copy link
Contributor

nreese commented Jan 27, 2021

@flash1293 maps_legacy has been converted to TS project so you should be unblocked now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants