Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Don't show x-dimension required when not required #81789

Closed
timroes opened this issue Oct 27, 2020 · 3 comments · Fixed by #81439
Closed

[Lens] Don't show x-dimension required when not required #81789

timroes opened this issue Oct 27, 2020 · 3 comments · Fixed by #81439
Assignees
Labels
discuss Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Oct 27, 2020

This is a follow up from an offline discussion @dej611 and I had.

Currently in Lens, when you just drag a time field into the y-axes we'll be left with an error stating the x-axes is required, but still draw the chart:

screenshot-20201027-160759

I think we should not show that error while we're able to draw a chart, since it obviously means the dimension is not really required. I understand there are some edge-cases and this issue should be to outline those and come to a conclusion whether we want to show that error or not in those scenarios.

cc @flash1293

@timroes timroes added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

I agree with you, @timroes - there is merit in pointing the user to complete the chart by adding an x axis, but I think in this case it causes more confusion than being helpful. IMHO users will get what to do even without pointing them there using an error message. The suggestion logic will still try hard to have an x axis in the chart in most scenarios (which is a good thing I think).

@wylieconlon As this was added as part of the percentage charts based on your comment (#70703 (comment)), would you be fine with removing the message?

@dej611 dej611 self-assigned this Oct 30, 2020
@wylieconlon
Copy link
Contributor

@flash1293 fine with me

@dej611 dej611 linked a pull request Nov 4, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants