Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Dashboard only mode has been removed #81690

Closed
kobelb opened this issue Oct 26, 2020 · 8 comments
Closed

[Breaking change] Dashboard only mode has been removed #81690

kobelb opened this issue Oct 26, 2020 · 8 comments
Labels
Breaking Change Feature:Dashboard Dashboard related features Feature:Upgrade Assistant Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kobelb
Copy link
Contributor

kobelb commented Oct 26, 2020

Change description

Which release will ship the breaking change?

8.0

Describe the change. How will it manifest to users?

Dashboard-only mode has been removed. Users are advised to use feature privileges instead. Any users who are assigned a role that is configured for dashboard only mode will be able to see other applications besides just Dashboards in Kibana.

How many users will be affected?

Some users will be impacted, but my hunch is that a minority of users will be impacted by this.

What can users do to address the change manually?

Create a new custom-role which only grants read-only access to the Dashboard feature, and assign this role in-place of the dashboard-only mode role

How could we make migration easier with the Upgrade Assistant?

This is a rather large ask, but we'd have to look at Kibana's Advanced Settings in each space to see which roles are specified as dashboard-only mode roles, and create/update custom roles which grant them read-only access to the Dashboard feature.

Are there any edge cases?

No

Test Data

Using the reserved role

POST /_security/user/old_user
{
  "password" : "password",
  "roles" : [ "kibana_dashboard_only_user" ],
  "full_name" : "Kibana User"
}

Using a custom role

POST /_security/role/old_role
{
  "applications" : [
      {
        "application" : "kibana-.kibana",
        "privileges" : [
          "all"
        ],
        "resources" : [
          "*"
        ]
      }
    ]
}
POST /_security/user/old_user
{
  "password" : "password",
  "roles" : [ "old_role" ],
  "full_name" : "Kibana User"
}
curl 'http://localhost:5601/api/kibana/settings' \
  -H 'kbn-xsrf: true' \
  -H 'content-type: application/json' \
  -u elastic:changeme \
  --data-binary '{"changes":{"xpackDashboardMode:roles":["old_role"]}}'

Cross links

N/A

@kobelb kobelb added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant Breaking Change labels Oct 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

I'm going to remove the Elasticsearch UI team label. This deprecation should be registered by the plugin owner via the core deprecations service (#94845). All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions!

@alisonelizabeth alisonelizabeth added Team:AppServices and removed Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@alisonelizabeth alisonelizabeth added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppServices labels Apr 19, 2021
@timroes timroes added Feature:Dashboard Dashboard related features and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure NeededFor:KibanaApp labels Aug 31, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 31, 2021
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@timroes
Copy link
Contributor

timroes commented Aug 31, 2021

@ThomThomson Can this one be closed?

@ThomThomson
Copy link
Contributor

Seems to me that this contains a bit more info about the change than #67617 did, and it includes pieces about the upgrade assistant which may be better described in #54755. Maybe we should consolidate some of this information before closing? @azasypkin

@azasypkin
Copy link
Member

Seems to me that this contains a bit more info about the change than #67617 did, and it includes pieces about the upgrade assistant which may be better described in #54755. Maybe we should consolidate some of this information before closing? @azasypkin

That's correct, I'm going to cover "upgrade assistant" bit in a separate PR and will close this issue as soon as I merge it.

@azasypkin
Copy link
Member

Handled in #110960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Feature:Dashboard Dashboard related features Feature:Upgrade Assistant Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

6 participants