[Time To Visualize] Add Functional Tests After Config Option Defaults to True

[ThomThomson]

Once the config option allowByValueEmbeddables is set to true by default, or removed. We will have to begin implementing functional test cases for testing all by value and by reference behaviours. This issue will track the functional tests that need to be implemented.

Panels By Value - Lens / Maps / Visualize

• Creating a new panel from dashboard by value (@clintandrewhall)
• Editing a panel by value, and saving and returning retains the same number of panels.
  • lens panels (@ThomThomson) [Time to Visualize] Dashboard By Value Testing Lens #89581
  • visualize panels (@cqliu1) [Time to Visualize] Adds functional tests for editing by value visualize embeddables #90241
  • map panels (@crob611) [Dashboard] Adds Dashboard Maps by value functional tests #90449
• Editing a panel by value, and saving and returning correctly applies edits.
  • lens panels (@ThomThomson)
  • visualize panels (@cqliu1)
  • map panels (@crob611)
• Editing a panel by value, and saving to library retains the same number of panels.
  • lens panels (@ThomThomson)
  • visualize panels (@cqliu1)
  • map panels (@crob611)
• Add a panel to library from the dashboard (@cqliu1)
• Unlink a panel from library on dashboard (@cqliu1)
• Creating a new embeddable from listing page breaks link to dashboard
  • Maps (@ThomThomson)
  • Visualize (@cqliu1)

Add from app by Value - Lens / Maps / Visualize #89245

• Create new visualization and add to new dashboard via new modal (@poffdeluxe)
• Create new visualization and add to existing dashboard via new modal (@poffdeluxe)
• Add existing visualization to new dashboard (@poffdeluxe)
• Add existing visualization to existing dashboard (@poffdeluxe)
• Verify that users that do not have certain dashboard privileges cannot add to dashboard (@poffdeluxe)

Remove State from URL #86939

• Unsaved changes persist when user navigates to another app. (@ThomThomson )
• View mode restores last saved panels (@ThomThomson )
• Edit mode restores unsaved panels (@ThomThomson )
• Unsaved edits do not show up after saving (@ThomThomson )
• Unsaved edits do not show up when the edited dashboard is the same as the saved dashboard (@ThomThomson )
• Unsaved changes show up properly in listing page (@ThomThomson )
• Unsaved changes to new dashboard show up in listing page (@ThomThomson)
• Delete unsaved changes from listing page. (@ThomThomson )
• New dashboard in progress warning. (@ThomThomson )
• Listing page restores unsaved edits (@ThomThomson )

Getting Started / Best Practices

Run the test server (to start ES/Kibana) from either root dir or x-pack dir: node scripts/functional_tests_server
Now you can run the runner to kick off the tests: node scripts/functional_test_runner

To limit the tests being run, you can add a --grep option to the runner command or change the describe of the test group to be describe.only

When writing tests, it might be necessary to add data-test-subj attributes to elements in the application that you need to interact with. You can then use the testSubjects service to easily select those elements.

[poffdeluxe]

Added a few tests to the list that specifically have to do with creating/editing visualizations from their app (Viz/Lens) and adding to a dashboard by-value using the new modal

[LeeDr]

• test that the Saved Objects page shows the relationship from a dashboard to the index pattern(s) which are related to via by-value visualization(s).
• test that exporting a dashboard with "Include related objects" exports the index pattern used by the by-value visualizations
• test importing exported dashboards along with related index pattern

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)