Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Lens editor should be able to use the active data in configuration #79194

Closed
wylieconlon opened this issue Oct 1, 2020 · 2 comments · Fixed by #79851
Closed

[Lens] Lens editor should be able to use the active data in configuration #79194

wylieconlon opened this issue Oct 1, 2020 · 2 comments · Fixed by #79851
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@wylieconlon
Copy link
Contributor

The Lens architecture is only able to use data tables while rendering, but not in configuration. This blocks some of the feature ideas that we have considered, such as:

Implementation details

Datasources and visualizations both have needs for the "active data," so it should be managed by the editor frame. The editor frame already has a responsibility of building the expression which fetches data, so we could insert some additional code to store the most-recently fetched tables and then provide those tables to visualizations and datasources. Some information is going to be commonly needed, especially a list of any categorical keys that are part of the results. The Lens editor can extract the most-commonly-used metadata and pass it into configurations.

@wylieconlon wylieconlon added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

This will be done as part of #74509 (we need it anyway for CSV export)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants