Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PID file management to core #77019

Closed
pgayvallet opened this issue Sep 9, 2020 · 1 comment · Fixed by #77037
Closed

Migrate PID file management to core #77019

pgayvallet opened this issue Sep 9, 2020 · 1 comment · Fixed by #77037
Assignees
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

The PID file management needs to be moved to core, probably inside the EnvironmentService, and the pid mixin needs to be removed.

export default Bluebird.method(function (kbnServer, server, config) {
const path = config.get('pid.file');
if (!path) return;
const pid = String(process.pid);

// writes pid file
pidMixin,

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Legacy Removal Issues related to removing legacy Kibana labels Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants