Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remove leaking abstraction from field switch in PopoverEditor #77017

Closed
mbondyra opened this issue Sep 9, 2020 · 3 comments
Closed

[Lens] Remove leaking abstraction from field switch in PopoverEditor #77017

mbondyra opened this issue Sep 9, 2020 · 3 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Sep 9, 2020

To fix after merging #75635 and fieldless column.
The PopoverEditor onClick handler has a piece of logic that depends on specific operationTypes. I could move it to the columnDefinition, but it requires bigger refactoring because on the top of that it depends on compatible field type – and field is something we plan to remove as a required parameter of column. For that reason, I think it's best to tackle it once we get the fieldless column in place

const isTermsToFilters = selectedColumn?.operationType === 'terms' && operationType === 'filters';

and later on:
if (incompatibleSelectedOperationType && !isTermsToFilters) {...}

@mbondyra mbondyra added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra changed the title [Lens] remove leaking abstraction from field switch in popovereditor [Lens] Remove leaking abstraction from field switch in popovereditor Sep 9, 2020
@mbondyra mbondyra changed the title [Lens] Remove leaking abstraction from field switch in popovereditor [Lens] Remove leaking abstraction from field switch in PopoverEditor Sep 9, 2020
@flash1293
Copy link
Contributor

@mbondyra Seems like this is fixed already, can we close?

@mbondyra
Copy link
Contributor Author

Yes, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants