Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] App Leave Confirmation is Always Triggered #75607

Closed
ThomThomson opened this issue Aug 20, 2020 · 3 comments
Closed

[Lens] App Leave Confirmation is Always Triggered #75607

ThomThomson opened this issue Aug 20, 2020 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ThomThomson
Copy link
Contributor

Kibana version: master, 7.9

Describe the bug: When editing a lens visualization, leaving even without making any edits, will trigger the app leave confirmation.

Steps to reproduce:

  1. Load any existing lens visualization from the visualize listing page
  2. Try to reload the page, or exit via the Visualize breadcrumb

Expected behavior: The app leave confirmation should only be triggered

Screenshots (if relevant):
Looking at a dif between lastKnownDoc?.expression and state.persistedDoc.expression, it seems like the x and y titles aren't properly loaded into the lastKnownDoc
Screen Shot 2020-08-20 at 4 53 00 PM

@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

flash1293 commented Aug 21, 2020

Thanks for reporting! @wylieconlon looks like this is the expression-incompatibility I mentioned in the meeting we already have in there because of the axis options PR.

It should be fixed with #74523 (as the expression won't be part of the saved object anymore)

@flash1293 flash1293 self-assigned this Aug 21, 2020
@wylieconlon
Copy link
Contributor

Fixed by #74523, just tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants