Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default generic types for alerts and actions plugin #74897

Closed
mikecote opened this issue Aug 12, 2020 · 1 comment · Fixed by #86623
Closed

Remove default generic types for alerts and actions plugin #74897

mikecote opened this issue Aug 12, 2020 · 1 comment · Fixed by #86623
Assignees
@gmmorris
Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Aug 12, 2020 •
edited
Loading

With the support of generics coming soon (#64147), this issue would track the enforcement to use generics for alert and action types (and other generic types provided). We can move the usage of Record<string, unknown and Record<string, any> to the areas that are causing failures when implementing this.

Also types using Record<string, any> should convert to Record<string, unknown>.
@mikecote mikecote added Feature:Alerting Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this issue Aug 12, 2020
Merged
@gmmorris gmmorris self-assigned this Dec 15, 2020
@gmmorris gmmorris mentioned this issue Dec 21, 2020
Merged
2 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmmorris gmmorris

Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Alerting] Encourage type safe usage of Alerting gmmorris/kibana
4 participants
@gmmorris @kobelb @mikecote @elasticmachine