Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Kibana are not picked up when developing third party plugins #71530

Closed
spalger opened this issue Jul 13, 2020 · 4 comments
Closed
Labels
Team:Operations Team label for Operations Team triage_needed

Comments

@spalger
Copy link
Contributor

spalger commented Jul 13, 2020

Hi,

Concerning developer experience pain, I would like to say that since Kibana 7.8.0, I don't have anymore core code hot reload.
I do yarn start, and if I change something in core code, I need to restart fully Kibana so that my change is applied. That's somewhat painful :(
Before Kibana 7.8.0, I didn't have this issue.

Originally posted by @fbaligand in #70733 (comment)

@fbaligand would you mind adding some reproduction steps here so that I can dig into this? yarn start runs Kibana in a mode where everything should be watched correctly, but but it's unclear what's not working and what directory you're executing yarn start in for instance.

@spalger spalger added Team:Operations Team label for Operations Team triage_needed labels Jul 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@fbaligand
Copy link
Contributor

Hi,

Thanks to have open a dedicated issue for that.
Then, here are some precisions:

  • I run exactly this command: yarn start --oss --no-watch
  • I get the issue on v7.8.0 tag
  • wether I run this command in my plugin directory ($KIBANA_HOME/plugins/enhanced-table) or directly in kibana home, I get the issue
  • strangely, changes in my plugin are taken hot way, but not kibana core code changes.
  • I reproduce also the issue on master branch (with no community plugin at all)
  • I run on Windows 10 OS.

I hope that I gave you enough details.

@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 12, 2021
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@tylersmalley
Copy link
Contributor

tylersmalley commented Mar 31, 2022

Sorry for the delay on this --no-watch applies to the optimizer, so this would be why the plugin isn't being updated. Removing that option should resolve this issue.

Please reopen this is still an issue after removing the flag.

@fbaligand
Copy link
Contributor

Thanks for the answer.
I confirm that I don't use --no-watch parameter anymore, and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team triage_needed
Projects
None yet
Development

No branches or pull requests

4 participants