Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Plugin Functional Tests.test/plugin_functional/test_suites/core_plugins/logging·ts - core plugins plugin logging writes info_pattern context to custom pattern appender #70149

Closed
kibanamachine opened this issue Jun 27, 2020 · 9 comments · Fixed by #70378
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 27, 2020

A test failed on a tracked branch

{ Error: expected [ '' ] to sort of equal [ 'CUSTOM - PATTERN [plugins.core_logging.info_pattern][INFO ] log2' ]
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_functional/test_suites/core_plugins/logging.ts:119:53)
  actual: '[\n  ""\n]',
  expected:
   '[\n  "CUSTOM - PATTERN [plugins.core_logging.info_pattern][INFO ] log2"\n]',
  showDiff: true }

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@azasypkin azasypkin added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed labels Jun 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover
Copy link
Contributor

@restrry could this be fixed by #70168?

@mshustov
Copy link
Contributor

@joshdover No, it seems to be a race condition problem.

@mshustov
Copy link
Contributor

I suspect the problem exists because both console.log and write to stdout are async by nature. That's why I used spies in the integration tests

Not sure if it would work out of the box for FTR tests, but it worth giving a try. Or we can move tests from functional tests with FTR to integration tests with jest as well.
Let me know if you don't have time, I can take a stab at it.

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@tylersmalley
Copy link
Contributor

Failures over the past seven days:

image

Currently we're probably averaging a failure a day across PR's/branches which isn't a lot. But if it persists we will probably want to skip until it can be resolved.

@joshdover
Copy link
Contributor

I'll try to move these to jest today, if it looks like it's going to take a lot of time, I'll merge a skip while I work out the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc triage_needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants