Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] The chart re-renders too often #68013

Closed
cchaos opened this issue Jun 2, 2020 · 2 comments · Fixed by #68637
Closed

[Lens] The chart re-renders too often #68013

cchaos opened this issue Jun 2, 2020 · 2 comments · Fixed by #68637
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 2, 2020

Kibana version: Master (post 7.8)

Describe the bug:

When dragging another field after having created a chart, when I hover over the existing chart it turns blank and goes into the loading state just to re-render again.

Expected behavior:

Don't re-render until AFTER having dropped tje field.

Screenshots (if relevant):

Screen Recording 2020-06-02 at 04 44 PM

@cchaos cchaos added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon added the bug Fixes for quality problems that affect the customer experience label Jun 2, 2020
@mbondyra mbondyra self-assigned this Jun 8, 2020
@mbondyra
Copy link
Contributor

mbondyra commented Jun 8, 2020

The issue lies here: https://github.com/elastic/kibana/pull/65675/files#diff-e0914c601f0915b0642a0b2a04911ea4R227 - we're passing a callback function that's not memoized and it causes the unnecessary rerender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants