Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visualizations] Add aggs argument to custom requestHandlers #67916

Closed
lukeelmers opened this issue Jun 1, 2020 · 1 comment · Fixed by #71423
Closed

[visualizations] Add aggs argument to custom requestHandlers #67916

lukeelmers opened this issue Jun 1, 2020 · 1 comment · Fixed by #71423
Labels
bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Jun 1, 2020 •
edited
Loading

Somewhere in between migration to the new platform and the expressions-based vis infrastructure, it seems we are no longer providing an aggs argument to custom requestHandlers.

esaggs (the default request handler) uses aggs, however it appears it was left out of the visualization_function fallback which is used for custom handlers. We should add this argument back so that it doesn't break vis development for folks relying on aggs in custom request handlers.

Related forum thread: https://discuss.elastic.co/t/how-to-access-aggregations-from-within-custom-request-handler/226445
@lukeelmers lukeelmers added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) regression Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) loe:small Small Level of Effort Team:AppArch labels Jun 1, 2020
@lukeelmers lukeelmers self-assigned this Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. triaged labels Jul 8, 2020
@lukeelmers lukeelmers removed their assignment Jul 13, 2020
@lukeelmers lukeelmers linked a pull request Jul 13, 2020 that will close this issue
[Visualizations] Pass 'aggs' parameter to custom request handlers #71423
Merged
@fbaligand fbaligand mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Visualizations] Pass 'aggs' parameter to custom request handlers fbaligand/kibana
2 participants
@lukeelmers @elasticmachine