Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "defaultRoute" advanced setting #66878

Closed
flash1293 opened this issue May 18, 2020 · 1 comment · Fixed by #68284
Closed

Migrate "defaultRoute" advanced setting #66878

flash1293 opened this issue May 18, 2020 · 1 comment · Fixed by #68284
Assignees
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

#63443 changed the default setting of defaultRoute to /app/home.

For users who already configured a defaultRoute starting with app/kibana, this will cause a double page load from now on in most cases (the only exceptions are default routes pointing to management).

This setting should be migrated. As the new paths are not known during migration (because this information is set in the setup methods of the respective plugins), it should be set to app/url_migrate. This will do the redirect of the legacy path to the right app client side without a page load.

If the URL starts with app/kibana#/management, it shouldn't be migrated yet.

We should hold off this task until near the feature freeze of 7.9 - if management is migrated till then, it won't be necessary to put in a special rule for it.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels May 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants