Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] [data.autocomplete] - Migrate core kibana autocomplete configs to data plugin #66085

Closed
2 tasks
lukeelmers opened this issue May 11, 2020 · 6 comments · Fixed by #100586
Closed
2 tasks
Assignees
Labels
blocker Breaking Change chore Feature:Search Querying infrastructure in Kibana Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort PR sent v8.0.0

Comments

@lukeelmers
Copy link
Member

Per the discussion in #46705, we need to migrate some of the yml config options which were previously part of the kibana plugin into data, where it makes more sense for them to live.

  • kibana.autocompleteTimeout -> data.autocompleteTimeout
  • kibana.autocompleteTerminateAfter -> data.autocompleteTerminateAfter

Note that the long term plan is to rename everything to snake_case (as discussed in #7444, this is something we would do all at once instead of incrementally). But for now we should rename to camelCase, and address conversion to snake case whenever that larger PR is put together.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

Hi @lukeelmers! In terms of how the Upgrade Assistant can help here, I think we could check for the existence of the deprecated settings and provide a code snippet with the replacement names. WDYT?

We also now have a 8.0 breaking change issue template that might be helpful to take a look at to provide additional context.

@lukeelmers
Copy link
Member Author

I think we could check for the existence of the deprecated settings and provide a code snippet with the replacement names. WDYT?

Thanks @alisonelizabeth! Yep I think a check like that would be just fine. We might have some other config names we are changing too, I'm taking a look at that and will let you know if there are any more to add.

@alisonelizabeth
Copy link
Contributor

I'm going to remove the Elasticsearch UI team label. Going forward, deprecations should be registered by the plugin owner via the core deprecations service (#94845). All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions!

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Apr 19, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 19, 2021
@ppisljar ppisljar added the Feature:Search Querying infrastructure in Kibana label May 10, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort labels May 24, 2021
@lukasolson lukasolson self-assigned this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Breaking Change chore Feature:Search Querying infrastructure in Kibana Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort PR sent v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants